Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GroupsList runtime function #31

Merged
merged 2 commits into from Jun 17, 2021
Merged

Add GroupsList runtime function #31

merged 2 commits into from Jun 17, 2021

Conversation

sesposito
Copy link
Member

@sesposito sesposito commented Jun 9, 2021 •
edited

TODO:

  • Add runtime function to TS definitions
  • Update docs

@sesposito sesposito requested a review from zyro June 9, 2021 18:37
zyro
zyro requested changes Jun 14, 2021
View reviewed changes
api/api.proto
google.protobuf.Int32Value limit = 3;
google.protobuf.Int32Value limit = 5;
// Optional Open/Closed filter.
google.protobuf.BoolValue open = 6;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-numbering may need discussion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the order so that the new fields are appended.

@sesposito sesposito merged commit 157deb0 into master Jun 17, 2021
@sesposito sesposito deleted the spe-add-group-listing branch June 17, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyro zyro zyro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sesposito @zyro