From 60dc264bfa9369ffce1545495f510309d5377b26 Mon Sep 17 00:00:00 2001 From: Mo Firouz Date: Sun, 11 Nov 2018 14:14:23 +0000 Subject: [PATCH] Increase metrics default report frequency to 60sec. --- CHANGELOG.md | 1 + server/config.go | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0b9fcb62b..3545511f9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ The format is based on [keep a changelog](http://keepachangelog.com) and this pr - New default for maximum number of open database connections. - Friend state indicators are no longer offset when sent to clients. - Group state indicators are no longer offset when sent to clients. +- Increased metrics default report frequency to 60sec. ### Fixed - Correctly handle optional parameters in runtime functions to update account information. diff --git a/server/config.go b/server/config.go index c0b8c18d6..e7901c85f 100644 --- a/server/config.go +++ b/server/config.go @@ -317,7 +317,7 @@ func NewLoggerConfig() *LoggerConfig { // MetricsConfig is configuration relevant to metrics capturing and output. type MetricsConfig struct { - ReportingFreqSec int `yaml:"reporting_freq_sec" json:"reporting_freq_sec" usage:"Frequency of metrics exports. Default is 10 seconds."` + ReportingFreqSec int `yaml:"reporting_freq_sec" json:"reporting_freq_sec" usage:"Frequency of metrics exports. Default is 60 seconds."` StackdriverProjectID string `yaml:"stackdriver_projectid" json:"stackdriver_projectid" usage:"This is the identifier of the Stackdriver project the server is uploading the stats data to. Setting this enables metrics to be exported to Stackdriver."` Namespace string `yaml:"namespace" json:"namespace" usage:"Namespace for Prometheus or prefix for Stackdriver metrics. It will always prepend node name."` PrometheusPort int `yaml:"prometheus_port" json:"prometheus_port" usage:"Port to expose Prometheus. If '0' Prometheus exports are disabled."` @@ -326,7 +326,7 @@ type MetricsConfig struct { // NewMetricsConfig creates a new MatricsConfig struct. func NewMetricsConfig() *MetricsConfig { return &MetricsConfig{ - ReportingFreqSec: 10, + ReportingFreqSec: 60, StackdriverProjectID: "", Namespace: "", PrometheusPort: 0,