Add Debug build flag. #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novabyte
reviewed
Feb 6, 2017
main.go
Outdated
| @@ -44,12 +43,18 @@ const ( | |||
| var ( | |||
| version string | |||
| commitID string | |||
| debugBuild bool = true | |||
There was a problem hiding this comment.
Let's convert this over to a --verbose flag in CLI arguments rather than as a build time constant.
|
@mofirouz Thanks. I'll merge it in. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
Add Debug build flag to enable debug logging and console output in development builds. This will disable processing of messages with
Zap.Level.Debug. It will also enable mirroring log out to the console in development builds.Various query tweaks for Friends and Storage.
Add additional log messages and enhancing a couple of existing ones.
Fix issue where random handle generator wasn't seeded properly.
Logout messages now close the connection as well and won't reply.
Fix sending Close frame message in the Websocket in order to gracefully close connection.