From 210c13d124968de71cb2c1d1069a13d5892fa81c Mon Sep 17 00:00:00 2001 From: Syo Ikeda Date: Wed, 18 Mar 2015 12:33:28 +0900 Subject: [PATCH] [Refactor] Use NSMutableSet for failed URLs' storage instead of array --- SDWebImage/SDWebImageManager.m | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/SDWebImage/SDWebImageManager.m b/SDWebImage/SDWebImageManager.m index 24167c149..4a94a7925 100644 --- a/SDWebImage/SDWebImageManager.m +++ b/SDWebImage/SDWebImageManager.m @@ -21,7 +21,7 @@ @interface SDWebImageManager () @property (strong, nonatomic, readwrite) SDImageCache *imageCache; @property (strong, nonatomic, readwrite) SDWebImageDownloader *imageDownloader; -@property (strong, nonatomic) NSMutableArray *failedURLs; +@property (strong, nonatomic) NSMutableSet *failedURLs; @property (strong, nonatomic) NSMutableArray *runningOperations; @end @@ -41,7 +41,7 @@ - (id)init { if ((self = [super init])) { _imageCache = [self createCache]; _imageDownloader = [SDWebImageDownloader sharedDownloader]; - _failedURLs = [NSMutableArray new]; + _failedURLs = [NSMutableSet new]; _runningOperations = [NSMutableArray new]; } return self; @@ -194,9 +194,7 @@ - (void)diskImageExistsForURL:(NSURL *)url if (error.code != NSURLErrorNotConnectedToInternet && error.code != NSURLErrorCancelled && error.code != NSURLErrorTimedOut) { @synchronized (self.failedURLs) { - if (![self.failedURLs containsObject:url]) { - [self.failedURLs addObject:url]; - } + [self.failedURLs addObject:url]; } } }