Fix dynamicHelpers so that it would resolve the urls. #5

Merged
merged 1 commit into from Jul 9, 2012

Conversation

Projects
None yet
2 participants
@mohamedmansour
Contributor

mohamedmansour commented Mar 23, 2012

There was a couple of errors with the dynamic helpers.

  1. scheme helper returns nothing, since there was no return statement for that helper.
  2. when passing an undefined path, that needs to be caught otherwise 'undefined' will be appended to the path
  3. cannot call dynamicHelper without req/res variable, doesn't work like that.

This will fix some issues where sharing the link, since those meta tags are needed to post the correct link to Facebook.

puffpio added a commit that referenced this pull request Jul 9, 2012

Merge pull request #5 from mohamedmansour/patch-1
Fix dynamicHelpers so that it would resolve the urls.

@puffpio puffpio merged commit 0d21bdb into heroku:master Jul 9, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment