New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass bouncer.refresh_token as well as bouncer.token. #46

Merged
merged 1 commit into from Jul 15, 2015

Conversation

Projects
None yet
2 participants
@recurser
Contributor

recurser commented Jun 22, 2015

Passes bouncer.refresh_token from heroku-oauth so that fresh tokens can be obtained in the future.

@wuputah

This comment has been minimized.

Show comment
Hide comment
@wuputah

wuputah Jun 22, 2015

Contributor

Thanks Dave. I purposely did not include refresh tokens for security reasons, but since this is behind expose_token I think it's okay to include refresh tokens.

cc/ @rhyselsmore do you see any issues here?

Contributor

wuputah commented Jun 22, 2015

Thanks Dave. I purposely did not include refresh tokens for security reasons, but since this is behind expose_token I think it's okay to include refresh tokens.

cc/ @rhyselsmore do you see any issues here?

@recurser

This comment has been minimized.

Show comment
Hide comment
@recurser

recurser Jun 23, 2015

Contributor

Hi @wuputah,

I purposely did not include refresh tokens for security reasons, but since this is behind expose_token I think it's okay to include refresh tokens.

I could put it behind something like expose_refresh_token if you'd prefer, so it needs to be explicitly opted-into?

Contributor

recurser commented Jun 23, 2015

Hi @wuputah,

I purposely did not include refresh tokens for security reasons, but since this is behind expose_token I think it's okay to include refresh tokens.

I could put it behind something like expose_refresh_token if you'd prefer, so it needs to be explicitly opted-into?

@recurser

This comment has been minimized.

Show comment
Hide comment
@recurser

recurser Jul 14, 2015

Contributor

Hi @wuputah / @rhyselsmore - any further thoughts on this?

Contributor

recurser commented Jul 14, 2015

Hi @wuputah / @rhyselsmore - any further thoughts on this?

@wuputah

This comment has been minimized.

Show comment
Hide comment
@wuputah

wuputah Jul 15, 2015

Contributor

:shipit:

Contributor

wuputah commented Jul 15, 2015

:shipit:

wuputah added a commit that referenced this pull request Jul 15, 2015

Merge pull request #46 from recurser/feature/pass-refresh-token
Pass bouncer.refresh_token as well as bouncer.token.

@wuputah wuputah merged commit fc63565 into heroku:master Jul 15, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment