Preserve ENV vars CPATH and CPPPATH (composable buildpacks) #30

Merged
merged 1 commit into from May 31, 2013

Projects

None yet

2 participants

@davidjrice
Contributor

Not overriding these variables entirely in the nodejs buildpack allows for it to be easily composable with others that provide dependencies not specifiable in an npm package.json using the heroku-buildpack-multi without having to hack the nodejs buildpack itself.

@davidjrice davidjrice referenced this pull request in ddollar/heroku-buildpack-multi Feb 26, 2013
Closed

Allow buildpack to export environment for subsequent packs #11

@zeke
Contributor
zeke commented May 30, 2013

Thanks for submitting this pull request @davidjrice. I don't see any immediate harm in merging this, but I'd like to better understand your use case first. Can you give a rundown of the multi-buildpack workflow you're using?

@davidjrice
Contributor

@zeke cool

The buildpacks used are.

  • heroku-buildpack-cairo
  • heroku-buildpack-nodejs

The rough workflow is

  • Install heroku-buildpack-cairo
  • This modifies environment variables CPPPATH, CPATH, LIBRARY_PATH, PKG_CONFIG_PATH and CFLAGS
  • Modification was required then for the node.js buildpack to not override any previously set ENV vars

The end result is that node-canvas installs gracefully under npm without hacking the library itself.

@zeke zeke merged commit 51fd8ec into heroku:master May 31, 2013
@zeke
Contributor
zeke commented May 31, 2013

Thanks for the patch, @davidjrice. It's been merged into the official buildpack! I'd love to see a blog post about how you wired this all together, as I've got some cairo/node-canvas aspirations of my own... 🤘

@searls searls referenced this pull request in linemanjs/heroku-buildpack-lineman Nov 14, 2013
Merged

Cache node_modules #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment