Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve ENV vars CPATH and CPPPATH (composable buildpacks) #30

Merged
merged 1 commit into from May 31, 2013

Conversation

davidjrice
Copy link
Contributor

Not overriding these variables entirely in the nodejs buildpack allows for it to be easily composable with others that provide dependencies not specifiable in an npm package.json using the heroku-buildpack-multi without having to hack the nodejs buildpack itself.

@zeke
Copy link
Contributor

zeke commented May 30, 2013

Thanks for submitting this pull request @davidjrice. I don't see any immediate harm in merging this, but I'd like to better understand your use case first. Can you give a rundown of the multi-buildpack workflow you're using?

@davidjrice
Copy link
Contributor Author

@zeke cool

The buildpacks used are.

  • heroku-buildpack-cairo
  • heroku-buildpack-nodejs

The rough workflow is

  • Install heroku-buildpack-cairo
  • This modifies environment variables CPPPATH, CPATH, LIBRARY_PATH, PKG_CONFIG_PATH and CFLAGS
  • Modification was required then for the node.js buildpack to not override any previously set ENV vars

The end result is that node-canvas installs gracefully under npm without hacking the library itself.

zeke added a commit that referenced this pull request May 31, 2013
Preserve ENV vars CPATH and CPPPATH (composable buildpacks)
@zeke zeke merged commit 51fd8ec into heroku:master May 31, 2013
@zeke
Copy link
Contributor

zeke commented May 31, 2013

Thanks for the patch, @davidjrice. It's been merged into the official buildpack! I'd love to see a blog post about how you wired this all together, as I've got some cairo/node-canvas aspirations of my own... 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants