default to latest versions of node and npm #31

Merged
merged 3 commits into from Mar 11, 2013

Projects

None yet

5 participants

@zeke
Contributor
zeke commented Feb 27, 2013

@ddollar take a look and let me know if this passes muster.

@Filirom1

Great ;)

Node 0.8.x is not the latest version of Node, 0.10.x is.

Contributor
zeke replied Apr 9, 2013

Touché, @sindresorhus. :)

This commit message is a bit of a misnomer; the current node version on master is 0.10.x

@zeke
Contributor
zeke commented Feb 28, 2013
heroku-buildpack-nodejs update_default_versions* $ anvil build . -b ddollar/test
Checking for app files to sync... done, 1 files needed
Uploading: 100.0%
Launching build process... done 
Preparing app for compilation... done 
Fetching buildpack... done 
Detecting buildpack... done, Test 
Fetching cache... done 
Compiling app... 
  Running bin/test
    testDetectWithPackageJson
    testDetectWithoutPackageJson
    testPackageJsonWithVersion
    testPackageJsonWithoutVersion
    testPackageJsonWithInvalidVersion
    testNothingCached
    testProfileCreated

    Ran 7 tests.

    OK
Writing .profile.d/buildpack.sh... done 
Putting cache... done 
Creating slug... done 
Uploading slug... done 
Success, slug is https://api.anvilworks.org/slugs/d2d58c1f-da49-4b63-b17f-e7d7da4f1077.tgz
@lookfirst

Great! node 0.10 is stable now. Let's add that too please. I really would love better domain support. http://blog.nodejs.org/2013/03/11/node-v0-10-0-stable/

@zeke zeke merged commit 427bd1e into master Mar 11, 2013
@lookfirst

heh. you may not want to default to 0.10 quite yet as not all npm packages support it yet. i was really only suggesting that you make 0.10.x available as an option. =)

@ddollar
Contributor
ddollar commented Mar 11, 2013

I think default to latest available stable makes a lot of sense. It's very easy to specify something like

"engines": { "node": "0.8.x" }

for stability, which IMO is a good practice.

@lookfirst

I'm just saying you might want to wait a couple weeks to let the modules
catch up. Let's say I'm doing development locally and I don't specify a
default in my package.json. @see issue #20
#20

I've got 0.8.x locally and everything is great. I then try to deploy to
heroku and my deploy fails. That is unnecessary frustration for the end
user in trying to figure out why things are failing.

Two of the modules which are failing right now are related to redis and
mongo. I suspect both are fairly heavily used on your system. ;-)

jon

On Mon, Mar 11, 2013 at 11:34 AM, David Dollar notifications@github.comwrote:

I think default to latest available stable makes a lot of sense. It's very
easy to specify something like

"engines": { "node": "0.8.x" }

for stability, which IMO is a good practice.


Reply to this email directly or view it on GitHubhttps://github.com/heroku/heroku-buildpack-nodejs/pull/31#issuecomment-14731665
.

@zeke zeke deleted the update_default_versions branch Jan 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment