Log out yarn version #426
Merged
Log out yarn version #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunterloftis
approved these changes
Jun 9, 2017
|
Tiny diffs FTW |
|
with version is unaligned in the screenshot |
|
an extra space |
kennethreitz
suggested changes
Jun 9, 2017
bin/compile
Outdated
| @@ -93,6 +93,9 @@ install_bins() { | |||
| echo "engines.node (package.json): ${node_engine:-unspecified}" | |||
| fi | |||
| echo "engines.npm (package.json): ${npm_engine:-unspecified (use default)}" | |||
| if $YARN; then | |||
| echo "engines.yarn (package.json): ${yarn_engine:-unspecified (use default)}" | |||
There was a problem hiding this comment.
i think we want one fewer spaces here
added 2 commits
June 9, 2017 11:49
|
Good eye, didn't even notice that. |
|
Fixed! |
kennethreitz
approved these changes
Jun 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #423
Cases:
Not using Yarn:
yarn.lockbut no version:yarn.lockwith version: