New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content of app/nltk_data not included in slug #356

Closed
prashnts opened this Issue Jan 21, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@prashnts

prashnts commented Jan 21, 2017

With the latest v97, data downloaded as part of slug compilation step (specified via post_compile hook) is not retained in the slug.

This worked fine in v85, and pinning back to v85 this still works.

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Jan 23, 2017

Contributor

you need to download the files to the CWD, not to /app.

Contributor

kennethreitz commented Jan 23, 2017

you need to download the files to the CWD, not to /app.

@prashnts

This comment has been minimized.

Show comment
Hide comment
@prashnts

prashnts Jan 23, 2017

Thanks; I've pinned to v85 in the meantime. I think it'd be nice to have a warning posted somewhere about this change so to not have a scare and failing builds coming as surprise! :)

The above mentioned post_compile hook is fairly popular way of getting the nltk data.

prashnts commented Jan 23, 2017

Thanks; I've pinned to v85 in the meantime. I think it'd be nice to have a warning posted somewhere about this change so to not have a scare and failing builds coming as surprise! :)

The above mentioned post_compile hook is fairly popular way of getting the nltk data.

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Feb 15, 2017

Contributor

I just added official nltk support to the buildpack!

Simply add a nltk.txt file with a list of corpora you want installed, and everything should work as expected.

Contributor

kennethreitz commented Feb 15, 2017

I just added official nltk support to the buildpack!

Simply add a nltk.txt file with a list of corpora you want installed, and everything should work as expected.

@prashnts

This comment has been minimized.

Show comment
Hide comment
@prashnts

prashnts Feb 17, 2017

Thank you! It looks like a good solution.

I'd whipped up a buildpack to download the corpora in a multi-buildpack configuration: prashnts/heroku-buildpack-textblob which seems unnecessary now.

prashnts commented Feb 17, 2017

Thank you! It looks like a good solution.

I'd whipped up a buildpack to download the corpora in a multi-buildpack configuration: prashnts/heroku-buildpack-textblob which seems unnecessary now.

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Apr 4, 2017

Contributor

@prashnts nice!

Contributor

kennethreitz commented Apr 4, 2017

@prashnts nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment