Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Detecting Django Applications with Settings Packages #56

Closed
JeffPaine opened this Issue Oct 8, 2012 · 4 comments

Comments

Projects
None yet
3 participants

Per discussion with @kennethreitz in #38:

Now that settings injection is disabled (in favor of using dj-database-url) it is possible to support recognition of Django projects (documentation) that use either a settings.py or a settings package.

Contributor

kennethreitz commented Oct 8, 2012

+1

I suspect this would mean modifying the detect script.

I don't presume to understand all the implications of making this change for Heroku, so I'll leave that decision to Heroku's Benevolent Python Dictators :)

Contributor

saulshanabrook commented Dec 9, 2012

Instead of using settings detection, it might be better to just check for manage.py. I don't know of any Django projects that don't have a manage.py at the root, but there might be other cases I haven't come across. See #39 for manage.py detection suport

Contributor

kennethreitz commented Dec 9, 2012

Yep! This is already written in the 'versions' branch.

@bionikspoon bionikspoon pushed a commit to bionikspoon/annotation-tool-heroku-buildpack-python that referenced this issue Mar 5, 2016

@zeke zeke Merge pull request #56 from heroku/pipefail
use pipefail to force exit when `npm install` fails.
b43097f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment