Tests: Support running only a subset of the test suites #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before `make test` ran all unit test suites against all stacks, which would take up to an hour locally. This could be sped up by using one of the stack-specific targets (such as `make test-heroku-18`), however there was still no way to only run one of the test suites. Now `make test` can be controlled more precisely using optional `STACK` and `TEST_CMD` arguments, eg: `make test STACK=heroku-16 TEST_CMD=test/versions` Travis has now been made to use this feature, which unblocks future Travis speedups (such as splitting the jobs up further in #1018) and means on Travis the correct Docker image is now used. The `tests.sh` script has been removed since it's unused after #839 and redundant given the make targets. Fixes #958. Fixes #1020.
edmorley
force-pushed
the
testing-make-targets
branch
from
e37303c
to
6c91739
Compare
Malax
approved these changes
Jul 28, 2020
edmorley
added a commit
that referenced
this pull request
Jul 28, 2020
This change (along with #1021, which skips an unnecessary docker build) reduces the wall clock time from ~22 minutes to 5-6 minutes. Even with the additional overhead from increased parallelism, the combined job duration (~50 minutes) has not increased due to the other time savings. Changes: - for the unit tests, each stack is now tested in its own job and so tested in parallel - the use of Travis stages has been removed, since by design it blocks later tasks on earlier stages having completed - reducing parallelism unnecessarily for this use case - all jobs except for the Hatchet job now use Travis' `minimal` image, and no longer install redundant Ruby + bundler - the `sudo: {required,false}` references have been removed, since Travis no longer supports its non-sudo container infrastructure so ignores that option Fixes #1019. [skip changelog]
edmorley
added a commit
that referenced
this pull request
Jul 28, 2020
This change (along with #1021, which skips an unnecessary docker build) reduces the wall clock time from ~22 minutes to ~6 minutes. Even with the additional overhead from increased parallelism, the combined job duration (~50 minutes) has not increased due to the other time savings. Changes: - for the unit tests, each stack is now tested in its own job and so tested in parallel - the use of Travis stages has been removed, since by design it blocks later tasks on earlier stages having completed - reducing parallelism unnecessarily for this use case - all jobs except for the Hatchet job now use Travis' `minimal` image, and no longer install redundant Ruby + bundler - the `sudo: {required,false}` references have been removed, since Travis no longer supports its non-sudo container infrastructure so ignores that option Fixes #1018. [skip changelog]
dryan
pushed a commit
to dryan/heroku-buildpack-python
that referenced
this pull request
Nov 19, 2020
Previously `make test` ran all unit test suites against all stacks, which would take up to an hour locally. This could be sped up by using one of the stack-specific targets (such as `make test-heroku-18`), however there was still no way to only run one of the test suites. Now `make test` can be controlled more precisely using optional `STACK` and `TEST_CMD` arguments, eg: `make test STACK=heroku-16 TEST_CMD=test/versions` Travis has now been made to use this feature, which unblocks future Travis speedups (such as splitting the jobs up further in heroku#1018) and means on Travis the correct Docker image is now used (see heroku#958). The `tests.sh` script has been removed since it's unused after heroku#839 and redundant given the make targets. Fixes heroku#958. Fixes heroku#1020.
dryan
pushed a commit
to dryan/heroku-buildpack-python
that referenced
this pull request
Nov 19, 2020
This change (along with heroku#1021, which skips an unnecessary docker build) reduces the wall clock time from ~22 minutes to ~6 minutes. Even with the additional overhead from increased parallelism, the combined job duration (~50 minutes) has not increased due to the other time savings. Changes: - for the unit tests, each stack is now tested in its own job and so tested in parallel - the use of Travis stages has been removed, since by design it blocks later tasks on earlier stages having completed - reducing parallelism unnecessarily for this use case - all jobs except for the Hatchet job now use Travis' `minimal` image, and no longer install redundant Ruby + bundler - the `sudo: {required,false}` references have been removed, since Travis no longer supports its non-sudo container infrastructure so ignores that option Fixes heroku#1018. [skip changelog]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
make testran all unit test suites against all stacks, which would take up to an hour locally. This could be sped up by using one of the stack-specific targets (such asmake test-heroku-18), however there was still no way to only run one of the test suites.Now
make testcan be controlled more precisely using optionalSTACKandTEST_CMDarguments, eg:make test STACK=heroku-16 TEST_CMD=test/versionsTravis has now been made to use this feature, which unblocks future Travis speedups (such as splitting the jobs up further in #1018) and means on Travis the correct Docker image is now used (see #958).
The
tests.shscript has been removed since it's unused after #839 and redundant given the make targets.Fixes #958.
Fixes #1020.
[skip changelog]