Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail compile if repo contains vendor/bundle #21

Closed
wuputah opened this issue Jun 12, 2012 · 2 comments
Closed

Fail compile if repo contains vendor/bundle #21

wuputah opened this issue Jun 12, 2012 · 2 comments

Comments

@wuputah
Copy link
Contributor

wuputah commented Jun 12, 2012

Thoughts?

Pros: Committing this directory is harmful, breaks native gems, etc.

Cons: People should be able to vendor everything if they really want to. (But there's a "right way" to do that, and this isn't it... (use bundle package))
@ddollar
Copy link
Contributor

ddollar commented Jun 12, 2012

npm has the "npm rebuild" command that rebuilds vendored deps for the current platform

@hone
Copy link
Member

hone commented Jun 12, 2012

We could just delete vendor/bundle before loading the cache. Thoughts?

@hone hone mentioned this issue Jun 12, 2012
Merged
@hone hone closed this as completed in d3e0584 Jun 13, 2012
bpaul pushed a commit to qstream/heroku-buildpack-ruby that referenced this issue Apr 3, 2015
@juno
Add support to specify bower version on deployment (heroku#21)
5d895a5
railsgod0090 added a commit to railsgod0090/heroku-buildpack-ruby that referenced this issue Feb 9, 2022
@railsgod0090
remove vendor/bundle if it exists
7768e79 
We need to do this to avoid issues with people adding their
vendor/bundle directories in their git repo and causing issues with
native extensions not being properly built. People should be using
`bundle pack` instead. See
heroku/heroku-buildpack-ruby#21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ddollar @wuputah @hone