New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce RailsRunner helper object #758

Merged
merged 21 commits into from May 31, 2018

Conversation

Projects
None yet
2 participants
@schneems
Contributor

schneems commented May 16, 2018

Allows us to detect multiple rails configurations while only having to pay the penalty of booting Rails once. The time spent booting rails via rails runner should also be drastically reduced in more recent versions of Rails with the use of spring and boot snap.

This PR also introduces a second configuration based warning for Rails users who are using compile set to true due to runtime performance implications and odd behavior resulting in support tickets.

schneems added some commits May 16, 2018

Introduce RailsRunner helper object
Allows us to detect multiple rails configurations while only having to pay the penalty of booting Rails once. The time spent booting rails via `rails runner` should also be drastically reduced in more recent versions of Rails with the use of spring and boot snap.

This PR also introduces a second configuration based warning for Rails users who are using compile set to true due to runtime performance implications and odd behavior resulting in support tickets.
@hone

hone approved these changes May 18, 2018

@schneems schneems merged commit 2022ef4 into master May 31, 2018

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
heroku/compliance All requirements completed. Reviewed by hone.
Details
license/snyk - Gemfile.lock (languages) No new issues
Details
security/snyk - Gemfile.lock (languages) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment