Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept a comma-separated list of ports to forward #16

Merged
merged 4 commits into from Aug 3, 2019
Merged

Conversation

@jkutner
Copy link
Contributor

@jkutner jkutner commented Jul 18, 2019

Supersedes #15

Copy link
Contributor

@RasPhilCo RasPhilCo left a comment

🏄

Loading

@beanieboi
Copy link
Member

@beanieboi beanieboi commented Jul 19, 2019

@jkutner Do we need backend changes for this? Otherwise looks good to me

Loading

@jclem
Copy link

@jclem jclem commented Jul 19, 2019

Should we remove the localPort option and its documentation?

Loading

@jkutner
Copy link
Contributor Author

@jkutner jkutner commented Jul 19, 2019

@beanieboi nope, no backend changes. I added you just to get another set of eyes on it.

Loading

@jkutner
Copy link
Contributor Author

@jkutner jkutner commented Jul 19, 2019

@jclem oh hmm, i didn't notice that localPort was affected. I need to think on that.

Loading

@jclem
Copy link

@jclem jclem commented Jul 19, 2019

@jkutner Perhaps we could make them mutually exclusive for backwards compatibility and just error out if both formats are used (the local port option and port:port or a list of ports), and then deprecate the local port argument.

Loading

commands/port.js Show resolved Hide resolved
Loading
@jkutner jkutner merged commit 3455707 into master Aug 3, 2019
2 checks passed
Loading
@jkutner jkutner deleted the jclem-master branch Aug 3, 2019
@jclem
Copy link

@jclem jclem commented Aug 5, 2019

🎉 Thanks @jkutner! When-ish will this be available in the CLI?

Loading

@axelson
Copy link

@axelson axelson commented Oct 9, 2019

@jclem This is now available in the heroku command line, at least when on

$ heroku version
heroku/7.33.1 darwin-x64 node-v11.14.0

By the way do you have a link to how to use heroku ps:forward to connect to Elixir/Erlang's observer? I can't find the link anymore (or maybe it was just on slack...)

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants