This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
netrc no longer being honoured #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for another core method. |
|
At the moment we have from_key Our options for the netrc method: from_netrc Do you have any suggestions? |
|
I'd do from_env myself. |
|
What do you think? A heroku.api.HerokuCore property relating to the session object. I don't think too many people use custom sessions that aren't requests based, so this should work. |
|
This project has been deprecated for some time, and is now being sunset. We recommend that you use the maintained https://github.com/martyzz1/heroku3.py instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within your history you have stated that netrc would no longer be honoured, this wasn't true though due to a feature of requests.
Is netrc support required in this tool? If so, it might be worthwhile into looking for another core method.