Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Empty forked app remains after fork failure #757

Closed
rwdaigle opened this Issue · 11 comments

5 participants

@rwdaigle

If the fork operation fails, the new app is left hanging around. It should probably be cleaned up on failure.

For example:

$ heroku create
Creating mysterious-lake-8964... done, stack is cedar
http://mysterious-lake-8964.herokuapp.com/ | git@heroku.com:mysterious-lake-8964.git

$ heroku fork --app mysterious-lake-8964
Creating fork mysterious-lake-8964-138... done
Copying slug... .failed
 !    No slug available for copy.

$ heroku apps
=== My Dev/Legacy Apps
mysterious-lake-8964
mysterious-lake-8964-138

/cc @ryanbrainard

@cheptsov

What is the workaround?

@ryanbrainard

You'll need to manually destroy the new app. From the example above, it would be like this:

$ heroku destroy --app mysterious-lake-8964-138

@rwdaigle Should this have been closed?

@cheptsov

So the fork is not possible? I need to change the region anyway.

@ryanbrainard

Can you please provide more details of the error you are seeing?

@cheptsov

Threre are two errors:

1) Logs show an exception that database connection cannot be established (it seems it tries to connect to the old url and is not able because of access denied from this host).
2) The deployment history says that there are no deployments. And I see that the git repo is empty.

@rwdaigle

@ryanbrainard this issues is still open - it's a dup issue that was closed (I believe that's what you meant?)

@cheptsov destroy the forked app as @ryanbrainard indicated. Then retry the fork and submit a support ticket with fork output if you're still having issues.

@ryanbrainard

@rwdaigle yeah it is. sorry, i was looking at the wrong status indicator.

@tomdickin

Just wanted to say I'm getting what appears to be the same behaviour, with the additional frustration that the empty app now can't be deleted. There is a prompt to delete the app when the fork first fails, but if you mistype the confirmation you end up with this un-deletable thing.

The app doesn't get listed anywhere, but all other commands act as if it still exists with the exception of the destroy command, which decides it definitely doesn't exist.

@pedro
Owner

Hi @tomdickin,

Odd, if the app doesn't show in heroku list it definitely doesn't exist.
Do you happen to have the output of that session or any other info that might help us debugging this?

In the meantime I'm closing this out as fork now does prompt to delete the app on failure!

Thanks

@pedro pedro closed this
@tomdickin

Is prompting to delete a broken app really the completed solution to this? Is there ever a case when a failed fork is a useful thing to keep? It seems like an odd gotcha to leave in place.

Having said that, I am very new to heroku, so perhaps there's a negative to automatically deleting the failed fork that I am unaware of.

@pedro
Owner

Good question! We just decided to be pretty conservative after a bug made it delete the original app (which happened if you tried to fork an app to the same name, eek). But now that the confirmation is in I kinda like how it allows us to further debug some errors.

Part of the challenge here is that fork is pretty much a client-side feature. If we move it into a proper API then we'll be able to make it more consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.