This repository has been archived by the owner. It is now read-only.

Control+A causes weirdness in console w/ gem 2.23.0 #275

Closed
swrobel opened this Issue Mar 30, 2012 · 10 comments

Comments

Projects
None yet
3 participants

swrobel commented Mar 30, 2012

I have a cedar app for which I'm pulling up a terminal using heroku run console and in 2.21.3, Control+a would bring me to the beginning of the input line, just like it does in Terminal.app. Now in 2.23.0, if I hit Control+a while at the end of the line after entering in something like a.b.c it seems to insert a tab or something. Not really sure what's happening but the console session gets jacked up from that point on.

Environment is Lion Terminal.app, Ruby 1.9.3, Heroku Gem 2.23.0

Owner

geemus commented Mar 30, 2012

I'm not having any luck reproducing this with the same setup. Any other outliers to your setup? What do the contents of your ~/.heroku folder look like? Sorry for the trouble here, but hopefully we can pin it down and get you back on track asap. Thanks!

swrobel commented Mar 30, 2012

It's bizarre. It doesn't always seem to happen, but here's a sequence that seems to be repeatable:

  1. Do something with an ActiveRecord object, like User.last.name & hit return
  2. Press up to pull up the same command
  3. Hit Control+A and watch the weirdness (at least it happens to me...)
Owner

geemus commented Apr 3, 2012

@swrobel - haven't gotten it to occur for me just yet. For clarity, when you say it doesn't always seem to happen, do you mean that it messes up only some of the Control+A's within a given session, or that it only does it within some sessions?

swrobel commented Apr 3, 2012

Meaning it only seems to happen after I've used the console for a bit. Definitely happens in the case above. Seems to have to do with the periods in the input but I'm not sure. I just know this wasn't happening until I updated heroku.

Owner

geemus commented Apr 3, 2012

I tried those reproduction steps a few times and things still seemed to work on my end. One of my fellow Herokai suggested that it might have to do with resizing. Is it possible that you resize the terminal window while the console is still running? He indicated he had seen issues like this in that case as the normal stuff terminal does to try to resize doesn't properly get sent and/or translate to the running remote process. Let me know if that is possible as the problem, otherwise we can keep digging. Thanks!

Owner

danp commented Apr 3, 2012

Having trouble with this too, narrowed it down to abfa040.

Owner

danp commented Apr 3, 2012

This fixes it for me and I think still addresses #260.

Owner

geemus commented Apr 3, 2012

@dpiddy - seems good, can you pull request and/or merge?

Owner

danp commented Apr 4, 2012

Pushed as f4b78b9.

Owner

geemus commented Apr 4, 2012

@dpiddy - Thanks!

@swrobel - sounds like this should probably fix your issue as well, but let me know if you try it and it doesn't. Also, I'm planning on releasing soon-ish so you can try it then as well. Let me know if this doesn't help though and we will revisit. Thanks!

@geemus geemus closed this Apr 4, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.