normalize drains:add messaging / bogus urls? #588

Open
mmcgrana opened this Issue Sep 25, 2012 · 2 comments

Projects

None yet

2 participants

@mmcgrana
Contributor

How about changing:

$ heroku drains:add syslog://mydrain.com:514 -a www
Successfully added drain syslog://mydrain.com:514

to:

$ heroku drains:add syslog://mydrain.com:514 -a www
Adding drain syslog://mydrain.com:514 to www... done

Also, I'm not sure what is going on here:

$ heroku drains:add blablabla -a www
Successfully added drain syslog://blablabla:514

is the client coercing this to the bogus URL or is that happening in the API?

@mmcgrana
Contributor

Also should update the text here: https://devcenter.heroku.com/articles/logging#syslog-drains.

It doesn't reflect either the current or desired behavior. I can handle that if you'd like.

@wuputah
Contributor
wuputah commented Dec 14, 2012

I, for one, would like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment