getMetadata refactor #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still wondering what the actual problem was, but I'm confident this refactor wasn't part of it. In order to minimize the number of possible changes I'd like to propose them one at a time, ensure they're deployed, and not causing errors before moving onto the next one. Thoughts? |
This was part of ffz/Optimize. I'm very sure this wasn't part of the problem. This dedents most of the logic & removes (what is in my opinion) the unnecessary bool return (it's a guard on the length of the bytes). Dedenting the majority of the logic in a function a go best practice.
freeformz
force-pushed
the
ffz/Optimize2
branch
from
a9b0834
to
bb424d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was part of ffz/Optimize. I'm very sure this wasn't part of the
problem.
This dedents most of the logic & removes (what is in my opinion) the
unnecessary bool return (it's a guard on the length of the bytes).
Dedenting the majority of the logic in a function a go best practice.