Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: OOM
Commits on Aug 8, 2013
  1. Fred Hebert

    configuring lager watermarks

    ferd authored
  2. Fred Hebert
  3. Fred Hebert

    Moving to a sys.config configuration

    ferd authored
    Rather than configuring specific apps in many places (bin/logplex,
    bin/devel_logplex, logplex_app.erl), configurations are moved to a
    sys.config file that can be loaded by adding `-config sys` to the `erl`
    exectuable, or loaded automatically when generating an OTP release.
Commits on Aug 7, 2013
  1. Fred Hebert

    Moving logging to lager

    ferd authored
    The current logplex version shows a point of contention for logs through
    using io:format/2. Although it is unlikely lager will help a lot with
    it given we don't log directly to disk (and this is where it shines in
    comparison to other logging engines), it's worth trying to see if things
    are improving with it.
    
    Custom log formats are used to make sure the production log format
    remains 100% identical to the former one. They will, however, be
    different during test runs because no specific care has been taken to
    make the lager config be compatible in test cases.
  2. Fred Hebert

    Adding hibernation timeouts on drains

    ferd authored
    An inactive drain or buffer (Receives no request from the outside world)
    should be sent to hibernation in order to trigger a full-sweep GC,
    compact the memory of the process, and reduce the overall load of the
    system, and possibly reducing memory fragmentation of the VM at the cost
    of slightly more CPU when it triggers.
    
    The timeout is implemented using the gen_fsm timeout option, which
    automatically resets timeout timers when a message is processed by the
    process. This should allow to generally catch any kind of inactivity and
    force hibernation of the processes.
    
    Note: it is not yet known if the timeout value of 5 seconds or the
    amount of timers setup/cancellations will have an impact of any
    significance on an active system or not. The values may need to be
    tweaked or the effort redirected towards manual GC if refc binaries keep
    on hogging the memory after this.
  3. Fred Hebert

    Making counters explicit for buffer size

    ferd authored
    The logplex_msg_buffer module is used extensively by drain processes
    that buffer request and need to be the least blocking possible under
    heavy load. The current implementation would recalculate the entire
    queue length on every call, which became both time consuming and CPU
    intensive when the buffer was full, which happens when you have to count
    lengths even more often.
    
    This patch makes it so that we have an explicit counter for the buffer
    so that we don't need to recalculate it all the time, lowering the
    contention for runtime for a given process.
    
    The module includes conversion clauses for all functions part of the API
    so that the code can be hot-reloaded without stopping, and just adapt to
    the new format.
  4. Fred Hebert

    Force hibernation on drain reconnect

    ferd authored
    When there's a timer being set for a reconnection, we force hibernation
    in order to do a fullsweep GC of the drain processes.
    
    This might incur a certain cost for very busy-but-disconnected
    processes, forcing a short pause, but the backoff timers for
    reconnections will act as rate limiters on this.
Commits on Aug 6, 2013
  1. Fred Hebert

    Support more transition versions

    ferd authored
    R16B01 and R16B01-swfi are forks of v69 that were supported for
    a while and need to be able to upgrade too.
  2. Fred Hebert
  3. Fred Hebert

    Move web responses before IO logging calls

    ferd authored
    With IO being blocking for individual processes due to Erlang's IO
    protocol and logplex using io:format/2 to log information, it is
    possible that a node that does a lot of logging has bad tail latencies
    on its API as reported by issues #49 and #51 on github.
    
    This quickfix, pending a rewrite of the logging system to be
    non-blocking and load-shedding, moves the logging outside of the
    critical path for part of the requests as a whole. Some requests, such
    as token creation for channels (POST /v2/channels/(\\d+)/tokens) still
    contain logs in said critical path and will only see minor improvements.
  4. Fred Hebert

    Update invalid log message for rfc5424

    ferd authored
    The HTTP API used to not accept the STRUCTURED-DATA field of logplex
    messages, but this is no longer true as of May 2013. The documentation
    (last edited before then) didn't reflect the change.
Commits on Jul 19, 2013
  1. Fred Hebert
  2. Fred Hebert

    Merge pull request #48 from heroku/refc-leak-quickfix

    ferd authored
    Quickfix for logplex refc binary leak
  3. Fred Hebert

    Quickfix for logplex refc binary leak

    ferd authored
    This fix is temporary. It garbage collects the node once it
    reaches too high of a memory threshold in an attempt to protect
    against failure due to OOMs following refc binaries leak.
Commits on Jul 16, 2013
  1. Fred Hebert

    Bump to R16B01

    ferd authored
Commits on Jul 9, 2013
  1. Omar Yasin
Commits on Jun 28, 2013
  1. Fred Hebert

    Getting chunked encoding working

    ferd authored
Commits on Jun 27, 2013
  1. Omar Yasin

    Merge pull request #47 from heroku/canary_fetch

    omarkj authored
    Merge Canary fetch to v69
  2. Omar Yasin

    Added some tests for `canary_fetch`. Since logplex

    omarkj authored
    doesn't use standard http to deliver the logs the
    body isn't tested in this test. That's something 
    I'd need to fix by writing a custom http client.
  3. Fred Hebert

    Moving from crypto:md5/1 -> crypto:hash/2

    ferd authored
    crypto:md5(Data) is getting deprecated in favour of
    crypto:hash(md5,Data) in R16B02, and R16B01 will be generating warnings
    for it.
    
    This is preemptively future-proofing the code so we can keep using
    warning-as-errors settings.
Commits on Jun 26, 2013
  1. Omar Yasin
  2. Omar Yasin
  3. Omar Yasin
  4. Omar Yasin

    Added a upgrade script for v69 (shard

    omarkj authored
    replacements)
  5. Fred Hebert

    Merge branch 'v68'

    ferd authored
  6. Omar Yasin

    Merge pull request #46 from heroku/shard_update

    omarkj authored
    Changes applied to the branch, so I'm merging it in to the master.
Commits on Jun 25, 2013
  1. Omar Yasin
  2. Omar Yasin
  3. Omar Yasin

    Check for the `LOGPLEX_NODE_NAME` variable and

    omarkj authored
    connect to it rather then the local node if it is
    set. This is mostly used for testing.
  4. Omar Yasin

    Removed the -s flag and added a -k flag to read

    omarkj authored
    from the file. Also did a bit of refactoring to
    be able to reuse more code.
  5. Fred Hebert

    Adding redgrid management escript

    ferd authored
    The escript allows to do a few operations on redgrid:
    
    - get the redgrid process status
    - get a list of connected nodes according to redgrid
    - suspend redgrid (and unregister from it)
    - resume redgrid (and connect to it)
    
    The script connects as a hidden node.
Commits on Jun 21, 2013
  1. add canary fetch logs endpoint

    Tristan Sloughter authored
  2. Omar Yasin

    Created a escript that updates shards in a running

    omarkj authored
    logplex node.
  3. Omar Yasin

    Added a shorthand to updating the single node, it

    omarkj authored
    still uses the old functions but if the plan is to
    stop using them this should be refactored to not
    use rpc-style gen_server calls.
  4. Omar Yasin

    Since there is now only one type of shard

    omarkj authored
    replacement the atom that separated the old two
    types is now redundant.
Something went wrong with that request. Please try again.