Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

netrc should use atomic file replacement #2

Open
dpiddy opened this Issue · 1 comment

2 participants

Dan Peterson Barry Allard
Dan Peterson
Owner

Currently the library writes directly to the file that was opened. To avoid corruption issues, it should write to a temp file close to the real file and use File.rename to atomically replace the old file.

This relates to #1; the file opened with Netrc.read should probably not be replaced until it's verified the contents will be valid.

Barry Allard

Yeap fixed that in the pull request. It should throw an exception if it can't parse what it serializes before it writes it. Upd: can't splel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.