Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remote env #7

Merged
merged 3 commits into from Mar 6, 2013

Conversation

Projects
None yet
3 participants
Contributor

csquared commented Mar 5, 2013

Adds capability for fetching ENV vars from remote apps instead of using the attachable resources functionality (allows us to update one config var and restart connected apps VS updating the config var and updating it in all connected apps).

Contributor

mattmanning commented Mar 5, 2013

+1

@jkakar jkakar commented on the diff Mar 6, 2013

lib/vault-tools/config.rb
@@ -2,6 +2,15 @@ module Vault
module Config
extend self
+ def remote_env(app, env)
+ heroku = Heroku::API.new
+ heroku.get_config_vars(app).body[env]
@jkakar

jkakar Mar 6, 2013

Owner

Which credentials are used by the heroku-api gem when this call is
made?

@jkakar

jkakar Mar 6, 2013

Owner

@csquared explained how it works in Campfire. We're going to use the
heroku-vault@herokumanager.com API key.

Owner

jkakar commented Mar 6, 2013

Nice work, +1!

As we discussed in Campfire, I wonder if it would be simpler/easier to
push config vars out from vault-core-follower whenever it gets
restarted. That would require keeping a list of apps to push to (not
such a bad thing) and would also mean that the apps wouldn't fail when
the Heroku API is having issues (like right now where a heroku config:get is failing).

Anyway, I think we should land this branch and run with it until we
decide that push is more desirable than pull.

@csquared csquared added a commit that referenced this pull request Mar 6, 2013

@csquared csquared Merge pull request #7 from heroku/remote-env
Adds capability for fetching ENV vars from remote apps instead of using the attachable resources functionality (allows us to update one config var and restart connected apps VS updating the config var and updating it in all connected apps).
9a22ed0

@csquared csquared merged commit 9a22ed0 into master Mar 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment