Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

support for windows null device redirections #31

Open
wants to merge 3 commits into from

1 participant

@zenpoy

Windows uses NUL: instead of UNIX /dev/null

@zenpoy zenpoy support for windows null device redirections
Windows uses NUL: instead of UNIX /dev/null
f042e7f
@zenpoy

This is a very small change, but a critical one because currently vulcan create app_name fails on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 26, 2012
  1. @zenpoy

    support for windows null device redirections

    zenpoy authored
    Windows uses NUL: instead of UNIX /dev/null
  2. @zenpoy

    moved null_dev before build

    zenpoy authored
  3. @zenpoy

    moved null_dev to be private

    zenpoy authored
This page is out of date. Refresh to see the latest.
Showing with 8 additions and 4 deletions.
  1. +8 −4 lib/vulcan/cli.rb
View
12 lib/vulcan/cli.rb
@@ -13,7 +13,7 @@
require "yaml"
class Vulcan::CLI < Thor
-
+
desc "build", <<-DESC
build a piece of software for the heroku cloud using COMMAND as a build command
if no COMMAND is specified, a sensible default will be chosen for you
@@ -27,7 +27,7 @@ class Vulcan::CLI < Thor
method_option :source, :aliases => "-s", :desc => "directory, tarball, or url containing the source"
method_option :deps, :aliases => "-d", :desc => "urls of vulcan compiled libraries to build with", :type=>:array
method_option :verbose, :aliases => "-v", :desc => "show the full build output", :type => :boolean
-
+
def build
app = read_config[:app] || "need a server first, use vulcan create"
@@ -148,8 +148,8 @@ def update
file.puts ".env"
end
- system "git add . >/dev/null"
- system "git commit -m commit >/dev/null"
+ system "git add . >" + null_dev
+ system "git commit -m commit >" + null_dev
system "git push heroku -f master"
heroku "config:add SECRET=#{config[:secret]} SPAWN_ENV=heroku HEROKU_APP=#{config[:app]} HEROKU_API_KEY=#{api_key} NODE_PATH=lib NODE_ENV=production"
@@ -160,6 +160,10 @@ def update
private
+ def null_dev
+ return test(?e, '/dev/null') ? '/dev/null' : 'NUL:'
+ end
+
def action(message)
print "#{message}... "
yield
Something went wrong with that request. Please try again.