Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added heron_control, changed heron_description to use with uuv_simulator #2

Merged
merged 33 commits into from Jul 26, 2018

Conversation

@Nirzvi1
Copy link
Contributor

Nirzvi1 commented Jun 27, 2018

No description provided.

@@ -2,6 +2,10 @@
Changelog for package heron_description
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

0.4.0 (2018-06-26)

This comment has been minimized.

Copy link
@tonybaltovski

tonybaltovski Jul 13, 2018

Member

Remove this, it get automatically generated when you use catkin_generate_changelog

@@ -1,7 +1,7 @@
<?xml version="1.0"?>
<package>
<name>heron_description</name>
<version>0.3.0</version>
<version>0.4.0</version>

This comment has been minimized.

Copy link
@tonybaltovski

tonybaltovski Jul 13, 2018

Member

Revert, this is done using catkin_prepare_release

<headingDrift>0.005</headingDrift>
<headingGaussianNoise>0.005</headingGaussianNoise>
</plugin>
</gazebo>

This comment has been minimized.

Copy link
@tonybaltovski

tonybaltovski Jul 13, 2018

Member

Spacing is off.

@@ -1,9 +1,13 @@
cmake_minimum_required(VERSION 2.8.3)
project(heron_description)

find_package(catkin REQUIRED COMPONENTS roslaunch)
find_package(catkin REQUIRED COMPONENTS
heron_msgs

This comment has been minimized.

Copy link
@tonybaltovski

tonybaltovski Jul 13, 2018

Member

Are heron_msgs needed? I don't see them used any where.

This comment has been minimized.

Copy link
@Nirzvi1

Nirzvi1 Jul 13, 2018

Author Contributor

Should I put "roslaunch" back in?

@tonybaltovski tonybaltovski requested a review from dniewinski Jul 13, 2018
<!-- Collision geometry mesh, usually in STL format (it is recommended to keep
this geometry as simple as possible to improve the performance the physics engine
regarding the computation of collision forces) -->
<xacro:property name="collision_mesh_file" value="file://$(find heron_description)/meshes/heron_base.stl"/>

This comment has been minimized.

Copy link
@dniewinski

dniewinski Jul 13, 2018

Contributor

Does the simulator use the collision mesh to calculate buoyancy? If so, simplifying this mesh may go a long way for efficiency

@tonybaltovski

This comment has been minimized.

Copy link
Member

tonybaltovski commented Jul 26, 2018

@dniewinski any remaining concerns?

@dniewinski

This comment has been minimized.

Copy link
Contributor

dniewinski commented Jul 26, 2018

LGTM

@tonybaltovski

This comment has been minimized.

Copy link
Member

tonybaltovski commented Jul 26, 2018

@Nirzvi1 can you rebase?

Nirzvi1 added 22 commits Jul 23, 2018
Deleted unnecessary comments
Set frequency to 20Hz (the default update frequency of the um6 IMU).
* Added heron_control package

* Deleted unnecessary comments from CMakeLists.txt

* Updated robot_localization.yaml

Deleted unnecessary comments
Set frequency to 20Hz (the default update frequency of the um6 IMU).

* Edited package.xml and moved heron_controller node from heron_control

* Updated package.xml description
@Nirzvi1 Nirzvi1 force-pushed the Nirzvi1:kinetic-devel branch from 9099501 to b2a94d7 Jul 26, 2018
@tonybaltovski tonybaltovski merged commit 16b29a7 into heron:kinetic-devel Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.