Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higher resolution stones and numbers? #205

Closed
lebigot opened this issue Mar 10, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@lebigot
Copy link

commented Mar 10, 2014

It would be nice if stones and their numbers had a higher resolution: this would make the numbers on the stone easier to read, and would give a more professional look to the game.

@herzbube

This comment has been minimized.

Copy link
Owner

commented Apr 5, 2014

Move numbers (and everything else on the board except the stones) are rendered live with CoreGraphics, so the resolution cannot be the problem. I suspect that the numbers appear blurred because of anti-aliasing taking place during the rendering process.

As for the stones, the images are sized 294x294, so the resolution should be more than sufficient, except maybe for the highest zoom levels. I suspect that the stones appear blurred because they are carelessly scaled down.

@herzbube herzbube added this to the 1.1.0 milestone Apr 5, 2014

@herzbube

This comment has been minimized.

Copy link
Owner

commented Apr 5, 2014

Assigning this issue to milestone 1.1.0, but I'm making no promise here :-) Top priority for 1.1.0 is upgrading the project to iOS 7.

@herzbube herzbube added prio 3 and removed feature labels Apr 5, 2014

herzbube added a commit that referenced this issue Jun 4, 2014

set contentsScale property on all CALayer objects to support Retina d…
…isplays (#205)

the contentsScale property, which exists both on UIView and CALayer, is
an important property for properly supporting Retina displays. UIKit
automatically sets the property to its correct value on UIView objects,
but does not do so on CALayer objects - there we need to manually set
the property.

after this commit, coordinate labels are now displayed crisp and sharp
on Retina displays.

herzbube added a commit that referenced this issue Jun 4, 2014

move numbers and the next move symbol are now drawn crisp on Retina d…
…isplays (#205)

the fix is to draw directly to the CALayer graphics context, instead of
drawing into a newly created CGLayer and then "pasting" that CGLayer
onto the CALayer.

herzbube added a commit that referenced this issue Jun 6, 2014

all remaining board elements are now drawn crisp on Retina displays (#…
…205)

the board elements that are visibly affected are: stones, the last move
marker, seki markers, star points, inconsistent territory dot symbols
and dead stone markers.
@herzbube

This comment has been minimized.

Copy link
Owner

commented Jun 6, 2014

My initial guess that anti-aliasing is responsible was wrong. The actual bug was that the drawing process simply did not take Retina displays into account. Until today I did not understand how drawing on Retina displays really works. I won't make that mistake again (I hope). Thanks for raising this issue, it was the prod I needed to take action.

@herzbube herzbube closed this Jun 6, 2014

@lebigot

This comment has been minimized.

Copy link
Author

commented Jun 6, 2014

Great! I was just about to send you a screenshot that showed the effect. This will make your program look much nicer to my eyes. :) I'm looking forward to the next release.

@herzbube

This comment has been minimized.

Copy link
Owner

commented Jun 6, 2014

Oh, it's a vast improvement, no doubt. But I also had to adapt the general look of the app to iOS 7, so I hope you won't be disappointed by that. Also, the next release will be iOS 7 only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.