Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement area scoring #30

Closed
herzbube opened this issue Dec 9, 2012 · 2 comments

Comments

Projects
None yet
1 participant
@herzbube
Copy link
Owner

commented Dec 9, 2012

See http://senseis.xmp.net/?Scoring and http://senseis.xmp.net/?TerritoryAndAreaScoring for details.

Make a user default for the choice of which method of scoring should be used by default. The reason: the user will likely be used to one or the other method, which will influence his or her play (under territory scoring it costs a point to play into one's own area, whereas under area scoring it costs a point not to play on a neutral point).

@ghost ghost assigned herzbube Dec 9, 2012

@herzbube

This comment has been minimized.

Copy link
Owner Author

commented Sep 6, 2013

Prio 3 > Prio 1.

All these previous versions Fuego has been playing by area scoring (Chinese) rules. This is probably why it sometimes plays seemingly stupid moves in the end game, causing it to lose the game when Little Go applied its territory scoring (Japanese) rules.

Alhtough Fuego can be told to use territory scoring (Japanese) rules (the GTP command is "go_param japanese_scoring 1"), this apparently does not work well in Fuego 1.1. It is therefore important to teach area scoring to Little Go, and - if possible - to switch the default to area scoring. This could be achieved by asking the user about his preference when the app is started for the first time after the version upgrade.

@herzbube

This comment has been minimized.

Copy link
Owner Author

commented Dec 7, 2013

Things to implement

  • Add new scoringSystem property to GoGameRules and to NewGameModel
  • Expose the NewGameModel property in the "New game" screen. Persist the user's choice in this screen as a user preference.
  • Automatically change komi when the user switches between scoring systems in the "New game" screen (6.5 for territory scoring, 7.5 for area scoring)
  • When the new game starts, configure the GTP engine according to the selected scoring system
  • Implement area scoring in GoScore
  • Change "Game info" screen to support area scoring properties
  • Add two new entries "stones captured by black|white" to the move statistics section of the "Game info" screen
  • Add new section "Area scoring" and new entry "Handicap compensation" to the "Scoring settings" screen

herzbube added a commit that referenced this issue Dec 7, 2013

rename GoScore property „territoryScoringEnabled“ to „scoringEnabled“ (
…#30)

also rename goScoreTerritoryScoring* notifications to goScoreScoring*.
this change is somewhat cosmetic, but necessary since we are about to
change GoScore to not only support territory scoring, but area scoring
as well.

herzbube added a commit that referenced this issue Dec 8, 2013

use separate default komi for area and territory scoring (#30)
default komi for area scoring is 6.5, for territory scoring it is 7.5.
if possible, user defaults are updated to use the new default. in
addition, komi is changed automatically to one of the defaults when the
user switches between scoring systems in the "New game" screen.

herzbube added a commit that referenced this issue Dec 8, 2013

Game info screen now displays captured stones in move statistics sect…
…ion (#30)

the upcoming area scoring will not display captured stones anymore
because they are not relevant in the area scoring system. some users
might still be interested to know the numbers, so we include them in
the move statistics.

herzbube added a commit that referenced this issue Dec 8, 2013

area scoring bugfixes (#30)
fix a few bugs frm the previous commits:
- NewGameCommand now applies the selected scoring system to the new game
- GoScore correctly updates the total white score
- Komi is not updated automatically on „New game“ screen when a game
  from the archive is loaded (.sgf files specify their own komi)

@herzbube herzbube closed this Dec 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.