Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment for IPs #1

Closed
BBcan177 opened this issue Dec 24, 2017 · 2 comments
Closed

Comment for IPs #1

BBcan177 opened this issue Dec 24, 2017 · 2 comments

Comments

@BBcan177
Copy link

BBcan177 commented Dec 24, 2017

For minerlist.txt and minerlist-all.txt, would you consider adding a "#" before the IPs?

This would allow for pfBlockerNG to parse these feeds and collect the Domains names and consider the IP as a comment as that format would follow most other domain based feed format.

Would you also consider adding a new IP feed for these IPs?

Also noticed the hostlist.txt has "xmr-eu1[.]nanopool[.]org" but the "minerlist-all"
has only "xmr-eu[.]nanopool[.]org"? Was just an observation.

Thanks for providing these Feeds!

@ZeroDot1
Copy link

That's a good idea.

@Hestat
Copy link
Owner

Hestat commented Dec 25, 2017

Thanks for the feedback, I've decided to keep just the minerlist-all for ease of updates. I've added the # commenting for proper parsing. Let me know if you see other improvements or slip ups.

I've added xmr-eu1[.]nanopool[.]org to the minerlist-all as well.

@Hestat Hestat closed this as completed Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants