[BUG] Error code 3 vs SSL Letsencrypt vs FTP creation

[franciscopaniskaseker]

Describe the bug
This is not really a bug, but it can make the user very confused and get an error that is not about what he is trying to do. So I can say it is a web gui blocking problem.

Supose this:

1. I added one domain and enabled
2. I create letsencrypt SSL
3. Sometime after that, I enabled cloudflare or other proxy
4. Sometime after that, I try to create an additional FTP account. When I try to create the FTP account and try to save, it also will try to create or maybe renew the SSL. As it is under proxy, the SSL part will fail with "error code 3". However the initial intention was to create FTP account and not touch the SSL configuration. The error "code 3" will be printed. And it will not make sense because the panel is saying that you can not create/renew SSL and you are trying to create FTP account.

To Reproduce
In the description.

Expected behavior
Instead of "error code 3", maybe more informative: "SSL creation/renew failed. Your changes will not be saved".
Some users instead of install self signed SSL cert, they issue a lets encrypt one and then add the proxy. Is not the best procedure, but is not wrong at all, because even invalid lets encrypt can be used to encrypt connections. And sometimes the user want to use "full ssl strict" feature, that need a valid SSL cert. So will be better to have a more informative message then just try to document what users must to do.

Operating system:
Ubuntu 20.04 LTS

Hestia Control Panel version:
1.4.1

[jaapmarcus]

hestiacp/func/main.sh

Lines 23 to 44 in b3b0ac5

	# Return codes
	OK=0
	E_ARGS=1
	E_INVALID=2
	E_NOTEXIST=3
	E_EXISTS=4
	E_SUSPENDED=5
	E_UNSUSPENDED=6
	E_INUSE=7
	E_LIMIT=8
	E_PASSWORD=9
	E_FORBIDEN=10
	E_DISABLED=11
	E_PARSING=12
	E_DISK=13
	E_LA=14
	E_CONNECT=15
	E_FTP=16
	E_DB=17
	E_RRD=18
	E_UPDATE=19
	E_RESTART=20

"Lets encrypt and saving while expired is always a problem". as I will attempt to create a new one. Self signed certificates should work fine have used it in the past

For UI design I know we need to replace it. It is on the to do list for ages....