Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: use recommended/latest CSIDriver apiVersion #162

merged 1 commit into from Dec 17, 2020


Copy link

@onpaws onpaws commented Nov 18, 2020

Today I created a new Kubernetes cluster (v1.19.4) on a Hetzner node. Everything worked in the normal way, except for a minor "cosmetic" issue when I setup the Hetzner csi-driver following the README. At that point I saw the following warning:

$ kubectl apply -f
Warning: CSIDriver is deprecated in v1.19+, unavailable in v1.22+; use CSIDriver

This PR is very simple and is intended to silence this warning by adopting the currently recommended apiVersion. I wanted to "scratch the itch" even if it's largely cosmetic for future Hetzner csi-driver users.

NOTE: I haven't tested this thoroughly, the key assumption I'm making is the actual API continues to be compatible. I believe this is the case, based on looking at the k8s public changelog, but please actually confirm this before merging. :)

upstream docs
mailing list
CSIDriver going GA in Kubernetes 1.18

@onpaws onpaws changed the title is deprecated; specify latest apiVersion Chore: use recommended/latest CSIDriver apiVersion Nov 18, 2020
Copy link

Hey @onpaws,

thank you! I will merge your request when we enable/release support for k8s 1.20. We will test k8s 1.20 when it is released and your change will be part of our tests. With the next release, we will (based on our release policy) drop the official support for k8s <1.18. Then your change will be merged :).

Copy link
Contributor Author

onpaws commented Dec 8, 2020

Thanks @LKaemmerling for letting me know, good luck!

@LKaemmerling LKaemmerling merged commit 90f6a24 into hetznercloud:master Dec 17, 2020
Copy link

Merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants