Chore: use recommended/latest CSIDriver apiVersion #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onpaws
changed the title
|
Hey @onpaws, thank you! I will merge your request when we enable/release support for k8s 1.20. We will test k8s 1.20 when it is released and your change will be part of our tests. With the next release, we will (based on our release policy) drop the official support for k8s <1.18. Then your change will be merged :). |
|
Thanks @LKaemmerling for letting me know, good luck! |
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I created a new Kubernetes cluster (v1.19.4) on a Hetzner node. Everything worked in the normal way, except for a minor "cosmetic" issue when I setup the Hetzner
csi-driverfollowing the README. At that point I saw the following warning:This PR is very simple and is intended to silence this warning by adopting the currently recommended
apiVersion. I wanted to "scratch the itch" even if it's largely cosmetic for future Hetzner csi-driver users.NOTE: I haven't tested this thoroughly, the key assumption I'm making is the actual API continues to be compatible. I believe this is the case, based on looking at the k8s public changelog, but please actually confirm this before merging. :)
upstream docs
mailing list
CSIDriver going GA in Kubernetes 1.18