From f11aa0df8056e7c406fd214570e032820f0559d7 Mon Sep 17 00:00:00 2001 From: Anurag <81210977+kranurag7@users.noreply.github.com> Date: Fri, 1 Dec 2023 16:34:09 +0530 Subject: [PATCH] feat(helm): remove "v" prefix from chart version (#565) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This makes sure that the chart version is fully semver compliant, as Helm expects. Fixes #529 Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com> Co-authored-by: Julian Tölle Release-As: 1.19.0-rc.0 --- .goreleaser.yml | 4 ++-- chart/Chart.yaml | 2 +- chart/values.yaml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.goreleaser.yml b/.goreleaser.yml index 4ecd9dd16..5efb6efb9 100644 --- a/.goreleaser.yml +++ b/.goreleaser.yml @@ -4,7 +4,7 @@ before: hooks: - go mod tidy - - ./scripts/release-generate-deployment-yamls.sh {{ if not .IsSnapshot }}v{{ end }}{{ .Version }} + - ./scripts/release-generate-deployment-yamls.sh {{ .Version }} builds: - id: hcloud-cloud-controller-manager @@ -59,6 +59,6 @@ publishers: ids: [""] checksum: true - cmd: ./scripts/publish-helm-chart.sh hcloud-cloud-controller-manager-{{ if not .IsSnapshot }}v{{ end }}{{ .Version }}.tgz + cmd: ./scripts/publish-helm-chart.sh hcloud-cloud-controller-manager-{{ .Version }}.tgz env: - CHART_REPO_REMOTE={{ .Env.CHART_REPO_REMOTE }} diff --git a/chart/Chart.yaml b/chart/Chart.yaml index 20f9b3cda..347e5d67c 100644 --- a/chart/Chart.yaml +++ b/chart/Chart.yaml @@ -1,4 +1,4 @@ apiVersion: v2 name: hcloud-cloud-controller-manager type: application -version: v1.18.0 # x-release-please-version +version: 1.18.0 # x-release-please-version diff --git a/chart/values.yaml b/chart/values.yaml index 2f9163103..795109d51 100644 --- a/chart/values.yaml +++ b/chart/values.yaml @@ -50,7 +50,7 @@ env: image: repository: hetznercloud/hcloud-cloud-controller-manager - tag: '{{ $.Chart.Version }}' + tag: 'v{{ $.Chart.Version }}' monitoring: # When enabled, the hccm Pod will serve metrics on port :8233