[Windows] Crash occurs at ToastNotificationManager::CreateToastNotifier when connecting server

[fujii]

1. Start HexChat
2. Network List
3. Connect
4. Crash

Unhandled exception at 0x00007FFFC83498FE (ucrtbase.dll) in hexchat.exe: Fatal program exit requested.

callstack:

ucrtbase.dll!00007fffc83498fe() Unknown
ucrtbase.dll!00007fffc8349036() Unknown
hexchat.exe!__scrt_unhandled_exception_filter(_EXCEPTION_POINTERS * const pointers) Line 75 C++
KernelBase.dll!00007fffc9df7e2e()   Unknown
ntdll.dll!00007fffccbed958()    Unknown
ntdll.dll!00007fffccbd5ac6()    Unknown
ntdll.dll!00007fffccbe9a9d()    Unknown
ntdll.dll!00007fffccb74f29()    Unknown
ntdll.dll!00007fffccb76bd4()    Unknown
KernelBase.dll!00007fffc9da1f08()   Unknown
vcruntime140.dll!00007fffc59b4582() Unknown
vccorlib140.dll!00007fffae99bae5()  Unknown
[External Code] 
hcnotifications-winrt.dll!Windows::UI::Notifications::IToastNotificationManagerStatics::CreateToastNotifier(Platform::String ^ __param0)    C++
hcnotifications-winrt.dll!Windows::UI::Notifications::ToastNotificationManager::CreateToastNotifier(Platform::String ^ __param0)    C++
hcnotifications-winrt.dll!notification_backend_init() Line 80   C++
hexchat.exe!notification_plugin_init(_hexchat_plugin * plugin_handle, char * * plugin_name, char * * plugin_desc, char * * plugin_version, char * arg) Line 179 C
hexchat.exe!plugin_add(session * sess, char * filename, void * handle, void * init_func, void * deinit_func, char * arg, int) Line 294  C
hexchat.exe!fe_idle(void * data) Line 387   C
glib-2.0.dll!000002557e70a0f7() Unknown
glib-2.0.dll!000002557e70b0ea() Unknown
glib-2.0.dll!000002557e70b5e0() Unknown
gtk-win32-2.0.dll!00007fff9b69cd5f()    Unknown
hexchat.exe!main(int argc, char * * argv) Line 1097 C
[External Code] 

It does not crash if if I remove hcnotifications-winrt.dll.

[fujii]

Unfortunately, it still happens.
How to reopen?

[Arnavion]

You built master with that change?

[fujii]

Yes, I did.
But, after rebooting Windows, I can not reprocude original problem even with unmodified v2.12.1.
This crash began one day suddenly as other mentioned #1588 (comment)
I will try agin if it will happen again with v2.12.1.
Please keep this bug closed. Thank you.

[Arnavion]

With unmodified 2.12.1 you should get mojibake in the toast notifications even if it doesn't crash.

[dragonble]

Hi, I have the same issue and hexchat still crash if I don't delete hcnotifications-winrt.dll

System : Windows 8.1
Hexchat build: 2.12.1 unmodified and basic install

[learn-more]

I will take a look at this.

[xaxxon]

Do you want me to reboot and see if the problem goes away or not reboot to make sure I can reproduce the problem for a potential fix?

[learn-more]

It probably wont be today, but if you can hold off rebooting until later this week that would help verifying a potential fix.

If you want to use hexchat in the mean time, temp removing hcnotifications-winrt.dll should allow hexchat to start.

[xaxxon]

I'll see what windows will let me do.

[learn-more]

@xaxxon : When the build is finished you can grab the binaries from here: https://ci.appveyor.com/project/TingPing/hexchat/build/1.0.51
It should show the exception encountered (hopefully)

[xaxxon]

Error loading notifications-winrt err 0x803e0105: the notification platform is unavailable. The notification platform is unavailable.

[learn-more]

Thanks!

This is WPN_E_PLATFORM_UNAVAILABLE, I will investigate how to handle / work around this.
In the mean time, can you check your event logs to see if something is there?

[learn-more]

@xaxxon Can you re-test with https://ci.appveyor.com/project/TingPing/hexchat/build/1.0.52 ?
This is a nicer implementation, that does not slam a message box in your face :)

[xaxxon]

My power went out so my computer rebooted. I saw no messages anywhere. Also, I noticed that I had turned off notifications in my windows 10 control panel, but was previously unable to even pull up the control panels settings window for "notifications and actions". Now it pulls up just fine, since the reboot.

…

On Fri, Apr 7, 2017 at 4:12 PM, Mark Jansen ***@***.***> wrote: @xaxxon <https://github.com/xaxxon> Can you re-test with https://ci.appveyor.com/project/TingPing/hexchat/build/1.0.52 ? This is a nicer implementation, that does not slam a message box in your face :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1755 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIychrCPYz-pZ9Rl8-J1kwIp4Sbnfh9ks5rtsLMgaJpZM4I6kuw> .