Very simple implementation and test for the send_message API method #116

Merged
merged 2 commits into from May 30, 2012

Conversation

Projects
None yet
2 participants
@micahcraig
Contributor

micahcraig commented May 7, 2012

This implementation uses to_json on a simple hash to produce the call payload, not LinkedIn::* classes as indicated in the commented-out implementation currently in place. The hash approach seemed to be a more straightforward technique for simply producing well formatted JSON, and since the LinkedIn Messaging API does not currently include any read functionality, there's no need to re-materialize the structure for external consumption. If you have a strong preference for a class based implementation, I'd be happy build it out.

This implementation has been tested against the production API, and confirmed to work as expected. I've provided a spec test in the same format as most of the other tests in api_spec.rb. If you'd like more extensive test validation, just let me know.

Thanks! This Gem is a huge help in building out our LinkedIn integration.

ryanatwork added a commit that referenced this pull request May 30, 2012

Merge pull request #116 from micahcraig/master
Very simple implementation and test for the send_message API method

@ryanatwork ryanatwork merged commit 19425f9 into hexgnu:master May 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment