Setup docker #32

ayshvab · 2017-07-25T23:15:54Z

Весьма базовый сетап, но приложение доступно на http://localhost:4000/ после последовательности make-ов:

make compose-build:

make compose-install-deps:

make compose-create-db

make compose-migrate-db

make compose

Помогите улучшить.

ayshvab · 2017-07-25T23:20:49Z

#17

icu0755 · 2017-07-26T06:22:38Z

Dockerfile

@@ -0,0 +1,20 @@
+FROM elixir:latest


может быть стоит зафиксировать версию, чтобы избежать неожиданностей в будущем.
FROM elixir:2.4.5

Может быть 1.4.5?

Конечно. Спасибо!

icu0755 · 2017-07-26T06:26:12Z

Dockerfile

@@ -0,0 +1,20 @@
+FROM elixir:latest
+
+RUN apt-get update && apt-get upgrade -y && \


сюда обычно добавляют чистку apt && rm -rf /var/lib/apt/lists/*

icu0755 · 2017-07-26T06:30:38Z

Makefile

+	docker-compose build web
+
+compose-install-deps:
+	docker-compose run web mix deps.get


я бы добавил установку зависимостей в Dockerfile

icu0755 · 2017-07-26T06:31:01Z

Makefile

+
+
+compile:
+	mix compile


тоже в Dockerfile

icu0755

ansible относится к другому тикету

commands

imamatory · 2017-07-26T15:38:43Z

config/dev.exs

@@ -39,5 +39,5 @@ config :codebattle, Codebattle.Repo,
  username: "postgres",


Значения должны подтягиваться из переменных окружения.

Исправляю

Не забудь про префикс переменных CODEBATTLE_

Уже сделал)

sashashakun · 2017-07-26T16:36:03Z

Как насчет сделать например make start который выполнит все эти команды?

ayshvab · 2017-07-26T16:38:37Z

Я добавил сервис test для тестов. Это лишнее? Проще оставить как было? :

compose-test:
	docker-compose run web make test

icu0755 reviewed Jul 26, 2017

View reviewed changes

Makefile Outdated

compile:

mix compile

Copy link

icu0755 Jul 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тоже в Dockerfile

icu0755 reviewed Jul 26, 2017

View reviewed changes

ayshvab added 7 commits July 26, 2017 10:50

add basic docker-compose setup

e3aa4ff

update config db hostname

a6e77ff

add docker-compose stuff

b58373b

fix deps

8c605e5

fix last line

78ad149

remove unnecessary

f1abd68

commands

add install deps and compile

d963ad0

krivtsov previously approved these changes Jul 26, 2017

View reviewed changes

imamatory reviewed Jul 26, 2017

View reviewed changes

ayshvab added 4 commits July 26, 2017 19:30

add .env

ca24130

add test service and .env

66a21fa

add testing through start test container

b6e5e3a

add get_env

103822c

ayshvab dismissed krivtsov’s stale review via 103822c July 26, 2017 16:32

mokevnin merged commit 6025f41 into hexlet-codebattle:master Jul 26, 2017

imamatory mentioned this pull request Jul 26, 2017

[WiP] Setup docker #31

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup docker #32

Setup docker #32

ayshvab commented Jul 25, 2017

ayshvab commented Jul 25, 2017

icu0755 Jul 26, 2017

staskjs Jul 26, 2017

icu0755 Jul 26, 2017

icu0755 Jul 26, 2017

icu0755 Jul 26, 2017

icu0755 Jul 26, 2017

icu0755 left a comment

imamatory Jul 26, 2017 •

edited

ayshvab Jul 26, 2017

imamatory Jul 26, 2017

ayshvab Jul 26, 2017

sashashakun commented Jul 26, 2017

ayshvab commented Jul 26, 2017 •

edited

		@@ -0,0 +1,20 @@
		FROM elixir:latest

		RUN apt-get update && apt-get upgrade -y && \

		@@ -39,5 +39,5 @@ config :codebattle, Codebattle.Repo,
		username: "postgres",

Setup docker #32

Setup docker #32

Conversation

ayshvab commented Jul 25, 2017

ayshvab commented Jul 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

icu0755 left a comment

Choose a reason for hiding this comment

imamatory Jul 26, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sashashakun commented Jul 26, 2017

ayshvab commented Jul 26, 2017 • edited

imamatory Jul 26, 2017 •

edited

ayshvab commented Jul 26, 2017 •

edited