Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce an option to change tag to inject Browsersync snippets #34

Open
wants to merge 1 commit into
base: master
from

Conversation

1 participant
@lulzneko
Copy link

commented Jun 21, 2019

This pull request introduces a new option.
It changes tags to inject Browsersync's snippets.

This is a workaround for #15 . (I could not solve the root cause of #15 )

Browsersync may not work if the same problem as issue #15 occurs. Because the snippet for Browsersync is injected into </ body>. The #15 issue causes </ body> not to be rendered, which can cause Browsersync to fail.

The option introduced by this pull request allows you to move the tag to be injected into the first half of the code.
This will avoid this problem. It is rendered reliably by being injected into the tag.

This option allows to use the Browsersync feature until #15 is resolved.

Alternatively, this option can provide a solution for themes without tags.
For example, it is recommended that the [Google HTML/CSS Style Guide] not use the optional <body> tag. This plugin can not be used than it is.

However, if this pull request makes other tags available, then the plug-in will be available.
Like this, it is a function that can be used not only for the #15 workaround but also for others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.