Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all packages to latest and include package-lock.json #50

Merged
merged 2 commits into from Mar 12, 2019

Conversation

3 participants
@tomap
Copy link
Contributor

commented Mar 10, 2019

Following the issues with a dependency that broke hexo-cli, it seems indispensible to include package-lock.json

For other repository of hexojs project, it is less important, but for this project, it is indispensible, because user have no easy possibility to lock dependency to a specific version as this project is supposed to be installed globaly

For reference, see #49 and linked issues

@coveralls

This comment has been minimized.

Copy link

commented Mar 10, 2019

Coverage Status

Coverage remained the same at 86.071% when pulling 1ed7ec7 on tomap:feature/lockPackage into aa05580 on hexojs:master.

@YoshinoriN
Copy link
Member

left a comment

LGTM 👍

@YoshinoriN YoshinoriN merged commit b526c61 into hexojs:master Mar 12, 2019

4 checks passed

codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 86.071%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.