New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit stdio for spawned git process #82

Merged
merged 1 commit into from Sep 19, 2017

Conversation

3 participants
@cy20lin
Copy link
Contributor

cy20lin commented Sep 18, 2017

Enable user input while deploying, so that git can get authorization info through stdin.

Inherit stdio for spawned git process
Enable user input while deploying.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 18, 2017

Coverage Status

Coverage remained the same at 90.0% when pulling 0251b1e on cy20lin:cy20lin/master into 056db8e on hexojs:master.

@NoahDragon

This comment has been minimized.

Copy link
Member

NoahDragon commented Sep 19, 2017

The code LGTM. Could you please elaborate a scenario which can use this change?

@cy20lin

This comment has been minimized.

Copy link
Contributor Author

cy20lin commented Sep 19, 2017

While I'm using hexo g to deploy blog to github repo through http, it prompts me for my user account and password to continue. However, hexo hangs and doesn't respond to my typing. Since the git process is spawned without inheriting the standard input from parent process (aka hexo), git could never get what it needs to proceed, causing the hangs and could only escape using Ctrl-C.

With this PR, it solves the problem as mentioned.

I'm on Windows MSYS2 mingw64 shell, using nodejs built from MinGW-w64.

@NoahDragon NoahDragon merged commit 456bb1a into hexojs:master Sep 19, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.0%
Details

@JLHwung JLHwung referenced this pull request Jan 7, 2019

Closed

Draft a new release #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment