Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Atom.xml to use correct namespace #105

Merged
merged 1 commit into from Nov 16, 2019

Conversation

@Kritner
Copy link
Contributor

Kritner commented Nov 12, 2019

As per https://tools.ietf.org/html/rfc4287#section-1.2, the correct xml namespace is "http://www.w3.org/2005/Atom". When https is used, some feed validators will fail validation, even though the "https" version of that URL is also valid.

fixes #104

As per https://tools.ietf.org/html/rfc4287#section-1.2, the correct xml namespace is "http://www.w3.org/2005/Atom", which some feed validators will validate against, even though the "https" version of that URL is also valid.  

fixes #104
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 12, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 6dd8ea4 on Kritner:patch-1 into a82dc89 on hexojs:master.

@Kritner

This comment has been minimized.

Copy link
Contributor Author

Kritner commented Nov 12, 2019

I rolled back my npm version of the feed generator to 1.2.2, and was able to confirm with the "http" version of the xml namespace, the feed validates correctly enough to say "valid" rather than failed:

image

image

@SukkaW
SukkaW approved these changes Nov 13, 2019
Copy link
Member

SukkaW left a comment

LGTM.

@tomap tomap merged commit 41a4505 into hexojs:master Nov 16, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@curbengh curbengh mentioned this pull request Nov 17, 2019
@Kritner Kritner deleted the Kritner:patch-1 branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.