Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some chore update #70

Merged
merged 4 commits into from Jan 31, 2019

Conversation

@h404bi
Copy link
Contributor

h404bi commented Jan 17, 2019

  • remove object-assign
  • remove useless files from npm module
    • npm pack --dry-run
npm notice
npm notice package: hexo-generator-feed@1.2.2
npm notice === Tarball Contents ===
npm notice 1.1kB package.json
npm notice 2.3kB atom.xml
npm notice 674B  index.js
npm notice 1.1kB LICENSE
npm notice 1.9kB README.md
npm notice 2.0kB rss2.xml
npm notice 1.4kB lib/generator.js
npm notice === Tarball Details ===
npm notice name:          hexo-generator-feed
npm notice version:       1.2.2
npm notice filename:      hexo-generator-feed-1.2.2.tgz
npm notice package size:  4.1 kB
npm notice unpacked size: 10.5 kB
npm notice shasum:        6bd84f1bf62e1bc0b43c60aa80fc3930767e7cb9
npm notice integrity:     sha512-xfNbBo3BZE+G3[...]81vhMiiHgRmiA==
npm notice total files:   7
npm notice
hexo-generator-feed-1.2.2.tgz
  • format LICENSE
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 17, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling d334682 on h404bi:master into fec1dac on hexojs:master.

@tomap

This comment has been minimized.

Copy link
Contributor

tomap commented Jan 18, 2019

One minor comment, the rest LGTM :)

@h404bi

This comment has been minimized.

Copy link
Contributor Author

h404bi commented Jan 29, 2019

@YoshinoriN If you have time, please consider reviewing this, too.

@YoshinoriN

This comment has been minimized.

Copy link
Member

YoshinoriN commented Jan 30, 2019

@h404bi
sure :)

@tomap

One minor comment

I can't find your review comment 🤔 Would you please check it ??

@tomap

This comment has been minimized.

Copy link
Contributor

tomap commented Jan 30, 2019

The comment was

you should not ignore package-lock.json, at some point, we might decide to commit it

But that's not blocking the PR. Do as you think is best

Copy link
Member

YoshinoriN left a comment

Would you please specify files like hexojs/hexo#3378 for shrink package size?

@YoshinoriN

This comment has been minimized.

Copy link
Member

YoshinoriN commented Jan 31, 2019

@tomap
Thanks. I understand :)

@YoshinoriN YoshinoriN merged commit 7295ba4 into hexojs:master Jan 31, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@YoshinoriN

This comment has been minimized.

Copy link
Member

YoshinoriN commented Jan 31, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.