Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): delete jscs & use eslint #72

Merged
merged 1 commit into from Feb 3, 2019

Conversation

@YoshinoriN
Copy link
Member

YoshinoriN commented Feb 3, 2019

jscs has already merged with eslint.

fix ESLint error

I fix 6 eslint error after migrate to eslint.

$ yarn eslint
$ eslint .

./hexo-generator-feed/lib/generator.js
   7:24  error  "hexo" is not published                                            node/no-unpublished-require
  14:22  error  Unexpected control character(s) in regular expression: \x00, \x1f  no-control-regex

./hexo-generator-feed/test/index.js
   16:22  error  Unexpected control character(s) in regular expression: \x00, \x1f            no-control-regex
   36:3   error  Unnecessary parentheses around expression                                    no-extra-parens
   39:3   error  Combine this with the previous 'var' statement with uninitialized variables  one-var
  116:35  error  Unnecessary escape character: \:                                             no-useless-escape

✖ 6 problems (6 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 3, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling b397303 on YoshinoriN:delete-jscs-and-use-eslint into b67e9de on hexojs:master.

2 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 3, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling b397303 on YoshinoriN:delete-jscs-and-use-eslint into b67e9de on hexojs:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 3, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling b397303 on YoshinoriN:delete-jscs-and-use-eslint into b67e9de on hexojs:master.

@tomap
tomap approved these changes Feb 3, 2019
@tomap tomap merged commit ac3ffcc into hexojs:master Feb 3, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@YoshinoriN YoshinoriN deleted the YoshinoriN:delete-jscs-and-use-eslint branch Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.