Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IDN): uriencode root value #93

Merged
merged 3 commits into from Oct 18, 2019

Conversation

@curbengh
Copy link
Contributor

curbengh commented Sep 8, 2019

The current approach does not encode the root value, this PR fixes that.
Similar to hexojs/hexo-generator-sitemap#66

This PR is necessary to be compatible with hexo v4 and v3 or older (forward & backward compatibility).

Supersede #88

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 8, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling f3052d0 on curbengh:idn into a513323 on hexojs:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 8, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling bd25eeb on curbengh:idn into 1192928 on hexojs:master.

@curbengh curbengh requested a review from tomap Sep 8, 2019
@curbengh curbengh mentioned this pull request Sep 10, 2019
1 of 2 tasks complete
@curbengh curbengh changed the title fix(IDN): uriencode root value WIP fix(IDN): uriencode root value Sep 11, 2019
@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Sep 11, 2019

Pending hexojs/hexo#3708

Edit: hexojs/hexo#3708 is compatible with encodeURL(), regardless whether the url/path is already encoded or not.

@curbengh curbengh changed the title WIP fix(IDN): uriencode root value fix(IDN): uriencode root value Sep 24, 2019
@curbengh curbengh force-pushed the curbengh:idn branch from bd25eeb to f86f15a Sep 24, 2019
@curbengh curbengh requested a review from hexojs/core Sep 24, 2019
@curbengh curbengh force-pushed the curbengh:idn branch from f86f15a to 330a6fb Oct 17, 2019
@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Oct 17, 2019

Rebased

@curbengh curbengh requested review from tomap and hexojs/core and removed request for hexojs/core and tomap Oct 17, 2019
@SukkaW
SukkaW approved these changes Oct 17, 2019
@curbengh curbengh merged commit 4ea5b4c into hexojs:master Oct 18, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@curbengh curbengh deleted the curbengh:idn branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.