Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no such file or directory error caused by sitemap.xml not includ… #50

Merged
merged 1 commit into from Jun 8, 2019

Conversation

@YoshinoriN
Copy link
Member

YoshinoriN commented Jun 4, 2019

…ed package

Why?

We specified which file includes or not in #49 and we decided includes index.js & lib directory.
But, this package must include sitemap.xml. If it does not include below error occurs.

INFO  Start processing
FATAL Something's wrong. Maybe you can find the solution here: https://hexo.io/docs/troubleshooting.html
Error: ENOENT: no such file or directory, open 'C:\Users\N.Yoshinori\site\node_modules\hexo-generator-sitemap\sitemap.xml'
    at Object.openSync (fs.js:431:3)
    at Object.readFileSync (fs.js:333:35)
    at module.exports (C:\Users\N.Yoshinori\site\_main\node_modules\hexo-generator-sitemap\lib\template.js:21:37)
    at Hexo.module.exports (C:\Users\N.Yoshinori\site\_main\node_modules\hexo-generator-sitemap\lib\generator.js:27:13)
    at Hexo.tryCatcher (C:\Users\N.Yoshinori\site\\_main\node_modules\bluebird\js\release\util.js:16:23)
    at Hexo.<anonymous> (C:\Users\N.Yoshinori\site\_main\node_modules\bluebird\js\release\method.js:15:3

Sorry, I made a mistake when review. this error is my fault...

@weyusi
Would you review it?

@YoshinoriN YoshinoriN requested a review from curbengh Jun 4, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 4, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling a7dfa45 on YoshinoriN:fix-sitemapxml-not-exist into 77bf38b on hexojs:master.

2 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 4, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling a7dfa45 on YoshinoriN:fix-sitemapxml-not-exist into 77bf38b on hexojs:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 4, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling a7dfa45 on YoshinoriN:fix-sitemapxml-not-exist into 77bf38b on hexojs:master.

@curbengh

This comment has been minimized.

Copy link
Contributor

curbengh commented Jun 5, 2019

yeah, I just realized it too, I should've tested npm publish --dry-run before PR.
please merge.

@YoshinoriN

This comment has been minimized.

Copy link
Member Author

YoshinoriN commented Jun 6, 2019

Hmm... It seems to require @hexojs/core teams review...

@hexojs/core
Would you someone check it?

@tcrowe
tcrowe approved these changes Jun 7, 2019
Copy link

tcrowe left a comment

Thank you, @YoshinoriN 👍

@tcrowe

This comment has been minimized.

Copy link

tcrowe commented Jun 7, 2019

Do we need to bump the version number in this PR? Maybe a different one?

@tcrowe

This comment has been minimized.

Copy link

tcrowe commented Jun 7, 2019

Thank you also, @weyusi

@YoshinoriN YoshinoriN merged commit a4fb0d8 into hexojs:master Jun 8, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@YoshinoriN

This comment has been minimized.

Copy link
Member Author

YoshinoriN commented Jun 8, 2019

Do we need to bump the version number in this PR? Maybe a different one?

No. This is a regression bug.
Thanks @tcrowe :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.