Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch minimatch to micromatch #57

Merged
merged 1 commit into from Aug 10, 2019

Conversation

@curbengh
Copy link
Contributor

curbengh commented Jun 29, 2019

See hexojs/hexo#3538 for more details.

@@ -36,13 +36,5 @@ module.exports = function(locals) {
};

function isMatch(path, patterns) {
if (!patterns) return false;

This comment has been minimized.

Copy link
@curbengh

curbengh Jun 29, 2019

Author Contributor

this is not needed anymore because skipRenderList won't be null.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 29, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 87e5554 on weyusi:micromatch into 5e5ccb0 on hexojs:master.

@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Jun 29, 2019

Depends on Node >=8.

@curbengh curbengh force-pushed the curbengh:micromatch branch from ae378ce to 87e5554 Jul 11, 2019
@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Jul 11, 2019

rebased

@curbengh curbengh requested a review from hexojs/core Aug 10, 2019
Copy link
Contributor

segayuu left a comment

LGTM!

@segayuu segayuu merged commit 45296ad into hexojs:master Aug 10, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@curbengh curbengh deleted the curbengh:micromatch branch Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.