Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default config #90

Merged
merged 5 commits into from Nov 20, 2019
Merged

fix: set default config #90

merged 5 commits into from Nov 20, 2019

Conversation

@curbengh
Copy link
Contributor

curbengh commented Oct 28, 2019

mainly to enable anchor links to be compatible with toc() helper. Fixes theme-next/hexo-theme-next#1168

All defaults are set in consistent with hexo-renderer-marked.

cc @anthonyhan

@curbengh curbengh requested a review from hexojs/core Oct 28, 2019
@curbengh curbengh requested review from hexojs/core and removed request for hexojs/core Nov 2, 2019
@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Nov 2, 2019

Ready for review.

@curbengh curbengh requested a review from SukkaW Nov 3, 2019
@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Nov 3, 2019

breaks should be true by default, to be consistent with hexo-renderer-marked's default.

@SukkaW

This comment has been minimized.

Copy link
Member

SukkaW commented Nov 3, 2019

This change might break current users'. We should mention it in release notes.

@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Nov 4, 2019

This change might break current users'. We should mention it in release notes.

I intend to do a major bump (to v4) after this. I also mention the defaults in the readme.

curbengh added 2 commits Nov 4, 2019
@curbengh curbengh requested a review from SukkaW Nov 4, 2019
@tomap

This comment has been minimized.

Copy link

tomap commented Nov 6, 2019

Maybe add in the doc the config to use to keep the current defaults <v4

@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Nov 9, 2019

Maybe add in the doc the config to use to keep the current defaults <v4

I can mention in the release note. there were no defaults prior to v4, to keep the defaults, can specify key with no value,

markdown:
  render:
  plugins:
  anchors:

I don't think it's necessary to put it in readme/wiki; by releasing a new version, we essentially drop support for prior versions.

@SukkaW
SukkaW approved these changes Nov 12, 2019
@curbengh curbengh merged commit 71689da into hexojs:master Nov 20, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage remained the same at 88.71%
Details
@curbengh curbengh deleted the curbengh:defaults branch Nov 20, 2019
@curbengh curbengh mentioned this pull request Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.