Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anchors): utilize slugize() of hexo-util #95

Merged
merged 2 commits into from Dec 11, 2019

Conversation

@curbengh
Copy link
Contributor

curbengh commented Dec 11, 2019

BREAKING CHANGE: anchors retain case by default

Noticed while reviewing #94, this plugin currently uses sluggo library. This PR replaces it with hexo-util slugize() used in hexo and hexo-renderer-marked.

This shares similar goal with #90 to bring consistency with hexo-renderer-marked. I think there'll be no more breaking change for v4. Later PRs are more on feature parity (features that enabled by default in hexo-renderer-marked).

curbengh added 2 commits Dec 11, 2019
BREAKING CHANGE: anchors retain case by default
@curbengh curbengh requested a review from hexojs/core Dec 11, 2019
@SukkaW
SukkaW approved these changes Dec 11, 2019
Copy link
Member

SukkaW left a comment

LGTM!

In release note, we need to mention an example configuration that could retain hexo-renderer-markdown-it@3's behavior.

@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Dec 11, 2019

In release note, we need to mention an example configuration that could retain hexo-renderer-markdown-it@3's behavior.

yep, I'm planning to do that.

@curbengh curbengh merged commit 9942456 into hexojs:master Dec 11, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage increased (+0.1%) to 93.548%
Details
@curbengh curbengh deleted the curbengh:anchors-default branch Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.