Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Google+ shared link button because the Google+ service has ended #136

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Remove Google+ shared link button because the Google+ service has ended #136

merged 1 commit into from
Jun 7, 2019

Conversation

lulzneko
Copy link
Contributor

@lulzneko lulzneko commented Jun 7, 2019

This pull request removes "Google+" from the article share button.

The Google+ service ended in April 2019. Therefore, it is necessary to delete it from the share button of the article.

Currently, when Google + 's share button is clicked, the Google+ end announcement page is displayed. Therefore, this button will not be used. So pull request for deletion.

e.g. URL of Google+ share from the demo site of this theme
https://plus.google.com/up/?continue=https://plus.google.com/share?url%3Dhttps://hexo.io/hexo-theme-landscape/hexo-theme-landscape/2013/12/24/long-title/

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@yoshinorin yoshinorin merged commit 5df5751 into hexojs:master Jun 7, 2019
@yoshinorin
Copy link
Member

@lulzneko
Thank you for your contribution 😃

@lulzneko lulzneko deleted the pr-remove-google-plus branch June 7, 2019 06:18
Pikaurd pushed a commit to Pikaurd/hexo-theme-landscape that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants