Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the banner image path as a configuration file (resolve #106) #138

Merged
merged 1 commit into from Jun 18, 2019
Merged

Set the banner image path as a configuration file (resolve #106) #138

merged 1 commit into from Jun 18, 2019

Conversation

lulzneko
Copy link
Contributor

@lulzneko lulzneko commented Jun 7, 2019

This pull request resolves Issues #106.
Set the banner image path at the top of the page from the configuration file.

As discussed in Issues #106, it may be better not to make binary changes to the default banner image in user's repository.

Create a new banner image file (e.g., in the assets directory) and specify its path from the configuration file.

Thank you.

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@yoshinorin yoshinorin merged commit 7e0bd67 into hexojs:master Jun 18, 2019
@yoshinorin
Copy link
Member

@lulzneko
Thank you for your contribution 😄

@lulzneko lulzneko deleted the pr-banner-image-path-config branch June 18, 2019 14:43
Pikaurd pushed a commit to Pikaurd/hexo-theme-landscape that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants