Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the banner image path as a configuration file (resolve #106) #138

Merged
merged 1 commit into from Jun 18, 2019

Conversation

2 participants
@lulzneko
Copy link
Contributor

commented Jun 7, 2019

This pull request resolves Issues #106.
Set the banner image path at the top of the page from the configuration file.

As discussed in Issues #106, it may be better not to make binary changes to the default banner image in user's repository.

Create a new banner image file (e.g., in the assets directory) and specify its path from the configuration file.

Thank you.

@YoshinoriN
Copy link
Member

left a comment

LGTM :)

@YoshinoriN YoshinoriN merged commit 7e0bd67 into hexojs:master Jun 18, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
@YoshinoriN

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

@lulzneko
Thank you for your contribution 😄

@lulzneko lulzneko deleted the lulzneko:pr-banner-image-path-config branch Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.