Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring up isExternalLink #119

Merged
merged 4 commits into from Nov 2, 2019

Conversation

@SukkaW
Copy link
Member

SukkaW commented Oct 28, 2019

Returns if a given url is external link relative to config.url and config.exclude.

Can be utilized in Hexo's external_link filter and hexo-filter-nofollow plugin.

@SukkaW SukkaW requested a review from curbengh Oct 28, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 28, 2019

Coverage Status

Coverage increased (+0.1%) to 95.425% when pulling a4a2873 on SukkaW:isExternalLink into 635161b on hexojs:master.

test/isExternalLink.spec.js Outdated Show resolved Hide resolved
@SukkaW SukkaW requested a review from curbengh Oct 28, 2019
@SukkaW

This comment has been minimized.

Copy link
Member Author

SukkaW commented Nov 2, 2019

@curbengh I might change filename to is_external_link.js

@SukkaW SukkaW requested a review from curbengh Nov 2, 2019
@curbengh

This comment has been minimized.

Copy link
Contributor

curbengh commented Nov 2, 2019

@curbengh I might change filename to is_external_link.js

please do.

@SukkaW

This comment has been minimized.

Copy link
Member Author

SukkaW commented Nov 2, 2019

@curbengh Filename changed in a4a2873

@SukkaW SukkaW merged commit 5c1ac62 into hexojs:master Nov 2, 2019
2 of 3 checks passed
2 of 3 checks passed
Travis CI - Pull Request Build Failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.1%) to 95.425%
Details
@curbengh curbengh mentioned this pull request Nov 20, 2019
0 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.