Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tocObj): bring up #137

Merged
merged 11 commits into from Dec 18, 2019
Merged

feat(tocObj): bring up #137

merged 11 commits into from Dec 18, 2019

Conversation

@SukkaW
Copy link
Member

SukkaW commented Nov 18, 2019

Close #136.

@SukkaW SukkaW requested review from curbengh and hexojs/core Nov 18, 2019
@SukkaW SukkaW force-pushed the SukkaW:tocobj branch from fccae67 to 86bce5b Nov 18, 2019
@SukkaW SukkaW mentioned this pull request Nov 18, 2019
1 of 2 tasks complete
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 18, 2019

Coverage Status

Coverage increased (+0.1%) to 96.595% when pulling 064d799 on SukkaW:tocobj into 621c9e3 on hexojs:master.

@curbengh curbengh mentioned this pull request Nov 21, 2019
@SukkaW

This comment has been minimized.

Copy link
Member Author

SukkaW commented Dec 3, 2019

IMHO, we should use another name for this feature. Maybe tocUtil() or parseToc()?

@curbengh curbengh mentioned this pull request Dec 12, 2019
0 of 2 tasks complete
README.md Outdated Show resolved Hide resolved
lib/toc_obj.js Outdated Show resolved Hide resolved
lib/toc_obj.js Outdated Show resolved Hide resolved
SukkaW and others added 6 commits Dec 13, 2019
@SukkaW SukkaW force-pushed the SukkaW:tocobj branch from 8ef7906 to 1f8b619 Dec 16, 2019
curbengh added 2 commits Dec 16, 2019
Copy link
Contributor

curbengh left a comment

Tested hexojs/hexo#3850 in a test blog.

@SukkaW SukkaW merged commit af3a386 into hexojs:master Dec 18, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.1%) to 96.595%
Details
@curbengh curbengh mentioned this pull request Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.