Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(isExternallink): no longer needs bind(hexo) #140

Merged
merged 1 commit into from Nov 22, 2019

Conversation

@SukkaW
Copy link
Member

SukkaW commented Nov 21, 2019

BREAKING CHANGES

In order to better utilizing isExternalLink(), this PR makes isExternalLink() no longer requires bind(hexo). sitehost & exclude will need to be passed after this PR.

Affected code:

hexojs/hexo#3835, hexojs/hexo#3847: New parameters will be needed.

hexo-filter-nofollow, hexojs/hexo-renderer-marked#116, hexojs/hexo-renderer-marked#119: hexo-filter-nofollow and hexo-renderer-marked will be able to utilize isExternalLink().

@SukkaW SukkaW requested review from curbengh and hexojs/core Nov 21, 2019
@SukkaW SukkaW changed the title refactor(isExternallink): no longer require bind hexo refactor(isExternallink): no longer need bind(hexo) Nov 21, 2019
@SukkaW SukkaW changed the title refactor(isExternallink): no longer need bind(hexo) refactor(isExternallink): no longer needs bind(hexo) Nov 21, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 21, 2019

Coverage Status

Coverage decreased (-0.008%) to 95.246% when pulling 83387af on SukkaW:refactor-isExternalLink into ad3541e on hexojs:master.

@curbengh

This comment has been minimized.

Copy link
Contributor

curbengh commented Nov 22, 2019

Since isExternalLink() is not used in released hexo yet, I think it's ok to include it in 1.6.0.

@SukkaW SukkaW merged commit b776026 into hexojs:master Nov 22, 2019
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.008%) to 95.246%
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.